Spin off PlatformApis thing into separate library#82
Spin off PlatformApis thing into separate library#82thaiphan wants to merge 1 commit intoaspnet:devfrom thaiphan:spin-off-library
Conversation
|
Hi @thaiphan, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution! The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR. TTYL, MSOTBOT; |
|
Has anybody had the opportunity to have a look at the pull request? |
|
If we do this, it would be a runtime interface and service. It shouldn't be in this repository. We'd also need a few more examples of APIs that could potentially use this. Do you have any other examples of consuming this? |
I was having trouble getting Edge.js working on Ubuntu and I'm pretty sure it's because of this line. The idea was make a pull request to Edge.js to take advantage of this spun off library. We can replace the code written in this pull request with the library. I think libgit2sharp might also be able to take advantage of the library. |
|
I don't imagine my pull request is particularly high priority but I'd at least appreciate some communication indicating such. |
|
Sorry about that. We're not likely going to take this pull request. FWIW, it has come up a few times having an API that can be used that's just like this. We haven't decided to make this the API and when we do decide, it might live in a separate repository, or even end up being a CLR API. For now I'd recommend copying the code. |
The whole cross-platform library loader helper stuff you guys have is pretty neat and I would like to use it for my own project. However, I'd rather not have a dependency on Kestrel so I just spun out the stuff I needed.