Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Spin off PlatformApis thing into separate library#82

Closed
thaiphan wants to merge 1 commit intoaspnet:devfrom
thaiphan:spin-off-library
Closed

Spin off PlatformApis thing into separate library#82
thaiphan wants to merge 1 commit intoaspnet:devfrom
thaiphan:spin-off-library

Conversation

@thaiphan
Copy link
Copy Markdown

The whole cross-platform library loader helper stuff you guys have is pretty neat and I would like to use it for my own project. However, I'd rather not have a dependency on Kestrel so I just spun out the stuff I needed.

@ghost
Copy link
Copy Markdown

ghost commented Mar 18, 2015

Hi @thaiphan, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.

TTYL, MSOTBOT;

@ghost ghost added the cla-not-required label Mar 18, 2015
@thaiphan
Copy link
Copy Markdown
Author

Has anybody had the opportunity to have a look at the pull request?

@davidfowl
Copy link
Copy Markdown
Member

If we do this, it would be a runtime interface and service. It shouldn't be in this repository. We'd also need a few more examples of APIs that could potentially use this. Do you have any other examples of consuming this?

@thaiphan
Copy link
Copy Markdown
Author

Do you have any other examples of consuming this?

I was having trouble getting Edge.js working on Ubuntu and I'm pretty sure it's because of this line. The idea was make a pull request to Edge.js to take advantage of this spun off library.

We can replace the code written in this pull request with the library.

I think libgit2sharp might also be able to take advantage of the library.

@thaiphan
Copy link
Copy Markdown
Author

I don't imagine my pull request is particularly high priority but I'd at least appreciate some communication indicating such.

@davidfowl
Copy link
Copy Markdown
Member

Sorry about that. We're not likely going to take this pull request. FWIW, it has come up a few times having an API that can be used that's just like this. We haven't decided to make this the API and when we do decide, it might live in a separate repository, or even end up being a CLR API.

For now I'd recommend copying the code.

@davidfowl davidfowl closed this Mar 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants