This repository has been archived by the owner on Nov 1, 2018. It is now read-only.
Enabling publishing portable apps #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #109
| @@ -20,21 +20,23 @@ public static int Main(string[] args) | |||
| app.HelpOption("-h|--help"); | |||
|
|
|||
| var publishFolderOption = app.Option("--publish-folder|-p", "The path to the publish output folder", CommandOptionType.SingleValue); | |||
| var frameworkOption = app.Option("-f|--framework <FRAMEWORK>", "Target framework of application being published", CommandOptionType.SingleValue); | |||
There was a problem hiding this comment.
Should we say something about this argument being required?
There was a problem hiding this comment.
We could. At the moment we don't say anything for --publish-folder so I did not add it here either. The reality is that typically people will not run it manually. Rather it will be in project.json in the post publish script section (created by our templates)
|
What does the new project.json tool script look like? |
|
Haven't tried it end to end but it should be something along these lines: |
|
We would also need to add configuration for this: #128. I think it is not for RC2 and it would be optional. |
|
"%publish:publish:" really? |
|
Copied incorrectly. It is just |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #109