-
Notifications
You must be signed in to change notification settings - Fork 59
The web.config file needs to have Windows slashes even if published o… #132
Conversation
1441dbc
to
a88e91d
Compare
// Forward slashes currently work neither in AspNetCoreModule nor in dotnet so they need to be | ||
// replaced with backwards slashes when the application is published on a non-Windows machine | ||
var appPath = Path.Combine(configureForAzure ? @"%home%\site" : ".", appName).Replace("/", "\\"); | ||
var logPath = Path.Combine(configureForAzure ? @"\\?\%home%\LogFiles" : @".\logs", "stdout.log").Replace("/", "\\"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the .log
extension.
ca37935
to
3af0651
Compare
AspNetCoreModule appends a timestamp followed by ".log" to log file name. Removing extension prevents from creating log files with names like stdout.log.{timestamp}.log
3af0651
to
7f77425
Compare
@@ -57,8 +57,10 @@ private static void TransformHandlers(XElement handlersElement) | |||
|
|||
private static void TransformAspNetCore(XElement aspNetCoreElement, string appName, bool configureForAzure) | |||
{ | |||
var appPath = Path.Combine(configureForAzure ? @"%home%\site" : ".", appName); | |||
var logPath = Path.Combine(configureForAzure ? @"\\?\%home%\LogFiles" : @".\logs", "stdout.log"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "stdout.log" still have the .log
on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per description of the commit:
AspNetCoreModule appends a timestamp followed by ".log" to log file name. Removing extension prevents from creating log files with names like stdout.log.{timestamp}.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ... gotcha ... thanks.
…n *nix
Addresses #104