Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

The web.config file needs to have Windows slashes even if published o… #132

Closed
wants to merge 3 commits into from

Conversation

moozzyk
Copy link
Contributor

@moozzyk moozzyk commented Apr 12, 2016

…n *nix

Addresses #104

// Forward slashes currently work neither in AspNetCoreModule nor in dotnet so they need to be
// replaced with backwards slashes when the application is published on a non-Windows machine
var appPath = Path.Combine(configureForAzure ? @"%home%\site" : ".", appName).Replace("/", "\\");
var logPath = Path.Combine(configureForAzure ? @"\\?\%home%\LogFiles" : @".\logs", "stdout.log").Replace("/", "\\");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the .log extension.

@Tratcher
Copy link
Member

:shipit:

@muratg
Copy link
Contributor

muratg commented Apr 14, 2016

:shipit:

moozzyk added 2 commits April 14, 2016 09:21
AspNetCoreModule appends a timestamp followed by ".log" to log file name. Removing extension prevents from creating log files with names like stdout.log.{timestamp}.log
@moozzyk moozzyk closed this Apr 14, 2016
@moozzyk moozzyk deleted the pawelka/forwardslash branch April 14, 2016 16:43
@@ -57,8 +57,10 @@ private static void TransformHandlers(XElement handlersElement)

private static void TransformAspNetCore(XElement aspNetCoreElement, string appName, bool configureForAzure)
{
var appPath = Path.Combine(configureForAzure ? @"%home%\site" : ".", appName);
var logPath = Path.Combine(configureForAzure ? @"\\?\%home%\LogFiles" : @".\logs", "stdout.log");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "stdout.log" still have the .log on it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per description of the commit:

AspNetCoreModule appends a timestamp followed by ".log" to log file name. Removing extension prevents from creating log files with names like stdout.log.{timestamp}.log

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ... gotcha ... thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants