Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Add optional feature to reject requests without IIS token #141

Closed
blowdart opened this issue Apr 20, 2016 · 3 comments
Closed

Add optional feature to reject requests without IIS token #141

blowdart opened this issue Apr 20, 2016 · 3 comments
Assignees
Milestone

Comments

@blowdart
Copy link
Member

This would prevent requests on the same machine bypassing auth/path authorization provided by IIS.

Should default to false though.

@Tratcher
Copy link
Member

Why default to false? Is there a mainstream scenario where you wouldn't want it on?

@Tratcher Tratcher self-assigned this Apr 20, 2016
@Tratcher Tratcher added this to the 1.0.0-rc2 milestone Apr 20, 2016
@Tratcher
Copy link
Member

Offline dicussion: On by default, no option to turn it off. The middleware is only added to the pipeline if the AspNetCoreModule environment variables are detected at startup, so enabling this will not affect self-host scenarios.

@kevinchalet
Copy link

kevinchalet commented Apr 22, 2016

Why not providing an option to disable this feature? What happens if I want to host my app in various environments? (e.g behind IIS on a Windows machine, behind nginx on a Linux-based machine).


Wooops, forget that, as mentioned, the integration middleware is only added if the ANCM environment variables are injected in the app process, so it shouldn't be a problem 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants