#600 Refactor to Equals in Path String, Adds Regression Tests #656

jkotalik · 2016-06-15T21:22:09Z

dnfclas · 2016-06-15T21:22:13Z

Hi @ZestyBread, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

jkotalik · 2016-06-15T21:24:42Z

@Tratcher @muratg Please review

Tratcher · 2016-06-15T21:29:17Z

src/Microsoft.AspNetCore.Http.Abstractions/PathString.cs

@@ -213,7 +213,7 @@ public string Add(QueryString other)
        /// <returns>True if both PathString values are equal</returns>
        public bool Equals(PathString other)
        {
-            return string.Equals(_value, other._value, StringComparison.OrdinalIgnoreCase);
+            return this.Equals(other, StringComparison.OrdinalIgnoreCase);


Remove this.

dnfclas · 2016-06-15T22:39:54Z

@ZestyBread, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

Tratcher · 2016-06-15T23:09:15Z

dnfclas added the cla-required label Jun 15, 2016

Tratcher reviewed Jun 15, 2016
View reviewed changes

dnfclas added cla-signed and removed cla-required labels Jun 15, 2016

jkotalik added this to the 1.0.1 milestone Jun 15, 2016

jkotalik self-assigned this Jun 15, 2016

Adds Refactor to Equals in Path String, Adds Regression Tests

d71c2cb

jkotalik force-pushed the JustinBranch branch from 25fbe6f to d71c2cb Compare June 15, 2016 23:32

jkotalik merged commit d71c2cb into dev Jun 15, 2016

jkotalik deleted the JustinBranch branch June 15, 2016 23:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#600 Refactor to Equals in Path String, Adds Regression Tests #656

#600 Refactor to Equals in Path String, Adds Regression Tests #656

jkotalik commented Jun 15, 2016

dnfclas commented Jun 15, 2016

jkotalik commented Jun 15, 2016

Tratcher Jun 15, 2016

dnfclas commented Jun 15, 2016

Tratcher commented Jun 15, 2016 •

edited by jkotalik

Loading

#600 Refactor to Equals in Path String, Adds Regression Tests #656

#600 Refactor to Equals in Path String, Adds Regression Tests #656

Conversation

jkotalik commented Jun 15, 2016

dnfclas commented Jun 15, 2016

jkotalik commented Jun 15, 2016

Tratcher Jun 15, 2016

Choose a reason for hiding this comment

dnfclas commented Jun 15, 2016

Tratcher commented Jun 15, 2016 • edited by jkotalik Loading

Tratcher commented Jun 15, 2016 •

edited by jkotalik

Loading