This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Add doc comments for FormOptions. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public long BufferBodyLengthLimit { get; set; } = DefaultBufferBodyLengthLimit; | ||
|
|
||
| /// <summary> | ||
| /// A limit for the number of form entries to allow. Entries with the same key will be combine. |
|
Address the comments, and |
|
|
||
| /// <summary> | ||
| /// If <see cref="BufferBody"/> is enabled, this is the limit for the total number of bytes that will | ||
| /// be buffered. Forms that exceed this limit will throw an <see cref="InvalidDataException"/> when parsed. |
There was a problem hiding this comment.
curious regarding usage of MemoryBufferThreshold vs. BufferBodyLengthLimit: If I want to buffer the data and also be safe from larger payloads, I could set the MemoryBufferThreshold alone...so wondering the use of BufferBodyLengthLimit
There was a problem hiding this comment.
MemoryBufferThreshold is not a hard limit, no exceptions will be thrown. It's just the amount of memory to use before switching to disk instead.
|
|
| public int KeyLengthLimit { get; set; } = FormReader.DefaultKeyLengthLimit; | ||
|
|
||
| /// <summary> | ||
| /// A limit on the length of individual form values. Forms that exceed this limit will throw |
There was a problem hiding this comment.
If a individual form entry value exceeds this limit then whatever will throw.
Tratcher
force-pushed
the
tratcher/formdocs
branch
from
291b530
to
7ebd87a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@muratg @blowdart @rynowak @kichalla