Return FormCollection.Empty when Content-Length is 0 (#1038)

* Return FormCollection.Empty when Content-Length is 0 Fixes aspnet/Mvc#5631
aspnet · Sep 13, 2018 · d0ddb06 · d0ddb06
1 parent cbafd89
commit d0ddb06
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Microsoft.AspNetCore.Http/Features/FormFeature.cs b/src/Microsoft.AspNetCore.Http/Features/FormFeature.cs
@@ -131,6 +131,11 @@ private async Task<IFormCollection> InnerReadFormAsync(CancellationToken cancell
 
             cancellationToken.ThrowIfCancellationRequested();
 
+            if (_request.ContentLength == 0)
+            {
+                return FormCollection.Empty;
+            }
+
             if (_options.BufferBody)
             {
                 _request.EnableRewind(_options.MemoryBufferThreshold, _options.BufferBodyLengthLimit);

diff --git a/test/Microsoft.AspNetCore.Http.Tests/Features/FormFeatureTests.cs b/test/Microsoft.AspNetCore.Http.Tests/Features/FormFeatureTests.cs
@@ -12,6 +12,23 @@ namespace Microsoft.AspNetCore.Http.Features
 {
     public class FormFeatureTests
     {
+        [Fact]
+        public async Task ReadFormAsync_0ContentLength_ReturnsEmptyForm()
+        {
+            var context = new DefaultHttpContext();
+            var responseFeature = new FakeResponseFeature();
+            context.Features.Set<IHttpResponseFeature>(responseFeature);
+            context.Request.ContentType = MultipartContentType;
+            context.Request.ContentLength = 0;
+
+            var formFeature = new FormFeature(context.Request, new FormOptions());
+            context.Features.Set<IFormFeature>(formFeature);
+
+            var formCollection = await context.Request.ReadFormAsync();
+
+            Assert.Same(FormCollection.Empty, formCollection);
+        }
+
         [Theory]
         [InlineData(true)]
         [InlineData(false)]