Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Remove UseServer overloads #731

Closed
davidfowl opened this issue Apr 27, 2016 · 4 comments
Closed

Remove UseServer overloads #731

davidfowl opened this issue Apr 27, 2016 · 4 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

davidfowl commented Apr 27, 2016

We're moving away from generic hosting understanding how to wire up servers to servers adding themselves to the DI container via first class extension methods. This also avoids issues where the default extension methods setup things by default (like a default set of options) so that it's possible to configure server settings in the application.

@muratg
Copy link

muratg commented Apr 28, 2016

This would be a breaking change, right? So in RC2? Could you start a thread for approval?

cc @Eilon @DamianEdwards

@Eilon
Copy link
Member

Eilon commented Apr 28, 2016

What exactly do we want to remove/change? And are these APIs already frequently used?

@muratg muratg added this to the 1.0.0 milestone May 9, 2016
@muratg
Copy link

muratg commented May 9, 2016

Let's revisit after RC2.

@Tratcher
Copy link
Member

Fowler's latest ask: Remove the extension, the config value, and the server factory that read the server value. Require servers be registered via DI in Main.

@muratg muratg assigned davidfowl and unassigned Tratcher May 19, 2016
davidfowl added a commit that referenced this issue May 19, 2016
- Removed the overload that takes a string because it's broken

#731
davidfowl added a commit that referenced this issue May 21, 2016
- Removed the overload that takes a string because it's broken

#731
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants