-
Notifications
You must be signed in to change notification settings - Fork 111
Move ICompilationException to Diagnostics.Abstractions #220
Comments
It also means that hosting will end up depending on this weird assembly 😄 |
Why would hosting need to depend on this assembly? |
Oh, it's used here for the startup exception page: https://github.com/aspnet/Hosting/blob/5bb737b6ad24edb8d9f77aa3b48b17b24b4dfc0d/src/Microsoft.AspNet.Hosting/Startup/StartupExceptionPage.cs#L54 |
That's meant for compile time exceptions (stuff coming from DNX) which we can leave as is. This was specifically for runtime compilation. |
Assigned to you @pranavkm. You'll have to leave a copy in DNX so that nothing breaks while we transition over. You can also remove the compilation error support from the Hosting page. |
Yeah - I'm going to rename the namespace for this interface so the current one can co-exist until we transition. For aspnet/Hosting#510, are we simply gutting the code? |
We use
ICompilationException
as a contract between diagnostics and other middlewares (primarily Mvc) that perform runtime compilation to show a pretty printed compilation failure. Currently the contract for this exception is located inMicrosoft.Extensions.CompilationAbstractions
. This would allow removing the CompilationAbstractions dependency.The text was updated successfully, but these errors were encountered: