API review: IScopedInstance needs design discussion

[muratg]

• What do we do with this interface?
• ScopedInstance also needs to be discussed

[davidfowl]

@HaoK @rynowak @dougbu @divega

Is it just MVC that uses this? We'd like to get rid or it.

/cc @lodejard

[dougbu]

@davidfowl a quick search of Universe shows IScopedInstance use in MVC and Entropy (but that's probably MVC-related). MVC uses the interface / default implementation to make some per-request contexts (ActionContext, ActionBindingContext, and AntiForgeryContext) available to MVC services without sticking the contexts directly into DI. are you suggesting we move IScopedInstance and ScopedInstance into MVC?

[HaoK]

Yeah when I did the rename i think it was only MVC/Entropy as well. +1 to just move these to MVC

[HaoK]

Some more context in Issue #49, it made more sense in DI when HttpContext was using this as part of the RequestContainer/Hosting code. But now that hosting is using its own HttpContextAccessor, there doesn't seem to be a reason to keep this shared anymore

[davidfowl]

Yea, I think step 1 is to remove the it from DI and step 2 is to figure out if MVC should be using this pattern at all. Last we discussed it it was an anti pattern like ITypeActivator.

[muratg]

Who would be doing the first step (i.e. remove it from DI and move it to MVC temporarily)? @rynowak

[HaoK]

I can do step 1 if needed, it shouldn't be hard

[muratg]

👍 Thanks!