Update Arcade#941
Merged
Merged
Conversation
martincostello
commented
Sep 9, 2024
martincostello
commented
Member
- Annual update of .NET Arcade for .NET 9.
- Fix new analysis warnings.
- Annual update of .NET Arcade for .NET 9. - Fix new analysis warnings.
martincostello
added
dependencies
kevinchalet
reviewed
Sep 9, 2024
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>portable</DebugType> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> |
Member
There was a problem hiding this comment.
We may want to revert that as the lack of snupkg support in Arcade is specific to their assets publishing process and shouldn't affect us (and honestly, snupkg is better than any other format).
We can easily ignore the warning using <SuppressSymbolPackageFormatValidation>true</SuppressSymbolPackageFormatValidation>: https://github.com/openiddict/openiddict-core/blob/d4c05e2e236c9fe6ecc2c97570b1cde7fac1a8ea/Directory.Build.props#L16-L17
Member
Author
There was a problem hiding this comment.
I agree - I just changed it because it broke the build.
ASP.NET Core 9's branch got a new version about 5 minutes after I checked the version...
Disable warning about using it instead.
martincostello
marked this pull request as ready for review
September 9, 2024 13:39
martincostello
added a commit
that referenced
this pull request
Nov 12, 2024
* Update to ASP.NET Core 9 preview 1 - Update to preview 1 of ASP.NET Core 9. - Use xunit's `TheoryData<T>`. - Fix new code analysis warnings and suggestions. - Disable noisy new CA1515 warning. - Update various dependencies to their latest versions. * Update .NET SDK to 9.0.100-preview.2.24157.14 (#842) * Update prerelease iteration Update for preview.2. * Use AdditionalAuthorizationParameters (#848) Ensure that overrides of `BuildChallengeUrl()` that do not call the base implementation add the values from the new `AdditionalAuthorizationParameters` property. See https://github.com/dotnet/aspnetcore/blob/ec293ee75c0c022370951a459b188fa81ec8b7c3/src/Security/Authentication/OAuth/src/OAuthHandler.cs#L331-L334. * Update .NET SDK to 9.0.100-preview.3.24204.13 (#853) * Update .NET SDK Update .NET SDK to version 9.0.100-preview.3.24204.13. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: aspnet-contrib-service-account[bot] <161750942+aspnet-contrib-service-account[bot]@users.noreply.github.com> * Bump .NET NuGet packages Bumps .NET dependencies to their latest versions for the .NET 9.0.100-preview.3.24204.13 SDK. Bumps Microsoft.AspNetCore.Authentication.Google from 9.0.0-preview.2.24128.4 to 9.0.0-preview.3.24172.13. Bumps Microsoft.AspNetCore.Mvc.Testing from 9.0.0-preview.2.24128.4 to 9.0.0-preview.3.24172.13. Bumps Microsoft.AspNetCore.TestHost from 9.0.0-preview.2.24128.4 to 9.0.0-preview.3.24172.13. --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-major - dependency-name: Microsoft.AspNetCore.TestHost dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: aspnet-contrib-service-account[bot] <161750942+aspnet-contrib-service-account[bot]@users.noreply.github.com> * Update prerelease iteration Update to preview 3. --------- Signed-off-by: aspnet-contrib-service-account[bot] <161750942+aspnet-contrib-service-account[bot]@users.noreply.github.com> Co-authored-by: aspnet-contrib-service-account[bot] <161750942+aspnet-contrib-service-account[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com> * Update to ASP.NET Core 9 preview 4 (#879) Update to preview 4 of ASP.NET Core 9. * Update to ASP.NET Core 9 preview 5 (#893) Update to preview 5 of ASP.NET Core 9. * Fix baselines Fix up package validation baselines. * Update baseline Update Docusign baseline for .NET 9. * Update to ASP.NET Core 9 preview 6 Update to preview 6 of ASP.NET Core 9. * Update to ASP.NET Core 9 preview 7 (#928) Update to preview 7 of ASP.NET Core 9. * Update Arcade (#941) - Annual update of .NET Arcade for .NET 9. - Fix new analysis warnings. * Update to .NET 9 RC1 Update to release candidate 1 of ASP.NET Core 9. * Bump System.Text.Encodings.Web Bump transient package reference to fix build. * Update to .NET 9 RC2 Update to release candidate 2 of .NET 9. * Remove unused action Remove unused setup action for NuGet. * Update to .NET 9 GA Update to the stable version of .NET 9. --------- Signed-off-by: aspnet-contrib-service-account[bot] <161750942+aspnet-contrib-service-account[bot]@users.noreply.github.com> Co-authored-by: aspnet-contrib-service-account[bot] <161750942+aspnet-contrib-service-account[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.