fix: make 'popular' categories use active_installs desc for order (#175)

aspirepress · Feb 23, 2025 · ef02a5b · ef02a5b
1 parent 5650811
commit ef02a5b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/app/Services/Plugins/QueryPluginsService.php b/app/Services/Plugins/QueryPluginsService.php
@@ -97,12 +97,12 @@ private static function applyTag(Builder $query, string $tag): void
      */
     private static function applyBrowse(Builder $query, string $browse): void
     {
-        // TODO: replicate 'featured' browse (currently it's identical to 'popular')
+        // TODO: replicate 'featured' browse (currently it's identical to 'top-rated')
         match ($browse) {
             'new' => $query->reorder('added', 'desc'),
             'updated' => $query->reorder('last_updated', 'desc'),
-            'top-rated', 'popular', 'featured' => $query->reorder('rating', 'desc'),
-            default => $query->reorder('active_installs', 'desc'),
+            'top-rated', 'featured' => $query->reorder('rating', 'desc'),
+            default => $query->reorder('active_installs', 'desc'),  // 'popular' is also the default
         };
     }
 

diff --git a/app/Services/Themes/QueryThemesService.php b/app/Services/Themes/QueryThemesService.php
@@ -48,9 +48,9 @@ private static function applyBrowse(Builder $query, string $browse): void
     {
         // TODO: replicate 'featured' browse (currently it's identical to 'popular')
         match ($browse) {
-            'popular', 'featured' => $query->reorder('rating', 'desc'),
+            'featured' => $query->reorder('rating', 'desc'),
             'new' => $query->reorder('creation_time', 'desc'),
-            default => null,
+            default => $query->reorder('active_installs', 'desc'), // 'popular' is also the default
         };
     }