Migrated to Asphalt 5 #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/csvimport.py
Outdated
| ready_callback=lambda bind, factory: metadata.create_all(bind), | ||
| ) | ||
| await super().start(ctx) | ||
| await super().start() |
There was a problem hiding this comment.
I need to check why mypy didn't pick this up.
There was a problem hiding this comment.
Right, I was looking at something else. It's not a syntax or typing issue. I'll do a a sweep on the subprojects to see if this is still present somewhere.
There was a problem hiding this comment.
I don't think it's wrong to await super().start(), just that it does nothing.
There was a problem hiding this comment.
I found a bunch of similar issues, plus outdated examples where add_component() was still called in start().
There was a problem hiding this comment.
Should be all good here now.
examples/csvimport_orm.py
Outdated
| ), | ||
| ) | ||
| await super().start(ctx) | ||
| await super().start() |
davidbrochart
approved these changes
Dec 30, 2024
|
I should address the coverage decrease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.