Skip to content

Allow pytest tests to be named test_ #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielrussoc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow pytest tests to be named test_ #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/pytest/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ py_library(
)

py_test(
name = "pytest_test",
name = "test_pytest_test",
srcs = ["foo_test.py"],
data = glob([
"fixtures/*.json",
Expand Down
3 changes: 2 additions & 1 deletion py/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ def py_test(name, srcs = [], main = None, pytest_main = False, **kwargs):
if pytest_main:
if main:
fail("When pytest_main is set, the main attribute should not be set.")
pytest_main_target = name + ".pytest_main"
# Add a prefix to the test main to ensure targets called "test_*" do not get discovered by pytest.
pytest_main_target = "zzz_" + name + ".pytest_main"
main = pytest_main_target + ".py"
py_pytest_main(name = pytest_main_target)
srcs.append(main)
Expand Down
Loading