Skip to content

chore: switch to bzl_library that checks docs #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2025
Merged

chore: switch to bzl_library that checks docs #655

merged 5 commits into from
Oct 15, 2025

Conversation

@alexeagle
Copy link
Member

@alexeagle alexeagle commented Oct 8, 2025

@alexeagle alexeagle requested a review from arrdem October 8, 2025 19:19
@aspect-workflows
Copy link

aspect-workflows bot commented Oct 8, 2025 •
edited
Loading

Test

All tests were cache hits

45 tests (100.0%) were fully cached saving 1m 36s.

@arrdem arrdem marked this pull request as ready for review October 15, 2025 00:42
@arrdem
Copy link
Collaborator

arrdem commented Oct 15, 2025

https://github.com/aspect-build/rules_py/actions/runs/18513663196/job/52759706481#step:3:916 Looks like we're leaking a bazel-lib dep into WORKSPACE builds that we need to satisfy to land this.

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

e2e/use_release folder: LCOV of commit afdb7ad during CI #2104

Summary coverage rate:
  lines......: 100.0% (2 of 2 lines)
  functions..: 100.0% (1 of 1 function)
  branches...: no data found

Files changed coverage rate: n/a

@arrdem arrdem enabled auto-merge (squash) October 15, 2025 01:36
@alexeagle alexeagle disabled auto-merge October 15, 2025 01:58
@alexeagle alexeagle merged commit a25b2cb into main Oct 15, 2025
20 checks passed
@alexeagle alexeagle deleted the stardocs branch October 15, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arrdem arrdem arrdem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeagle @arrdem @aspect-marvin