Remove determine_main rule #641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
keith
force-pushed
the
ks/remove-determine_main-rule
branch
from
b449adf to
62920f5
Compare
This inlines this into the executable rules instead. Fixes aspect-build#605 Fixes aspect-build#621
keith
force-pushed
the
ks/remove-determine_main-rule
branch
from
62920f5 to
012a826
Compare
keith
commented
Sep 11, 2025
| # NB: we don't use the py_binary macro here, because we want our `main` attribute to be used | ||
| # exactly as specified here, rather than follow rules_python semantics. | ||
| py_binary_rule( | ||
| py_binary( |
Contributor
Author
There was a problem hiding this comment.
I don't follow what this was testing, but it was trying to force a main file w/o any srcs. if im missing something this case likely doesn't work with this change
arrdem
added a commit
that referenced
this pull request
Nov 5, 2025
Determining the main using suffix matching was always a goofy idea. The underlying rules have long required that main be a label. Rip out determine_main and provide minimal default semantics for main as part of the existing wrapper macros. Those too should go away, but for now we have them. Replaces #641 with thanks to Keith.
Collaborator
|
Closing in favor of just ditching this behavior. |
arrdem
added a commit
that referenced
this pull request
Nov 5, 2025
Determining the main using suffix matching was always a goofy idea. The underlying rules have long required that main be a label. Rip out determine_main and provide minimal default semantics for main as part of the existing wrapper macros. Those too should go away, but for now we have them. Replaces #641 with thanks to Keith.
arrdem
added a commit
that referenced
this pull request
Nov 7, 2025
Vendor `rules_python`'s `determine_main` and remove the need for a separate `determine_main` target which complicates exec properties. Replaces #641 with thanks to Keith. Fixes #605 Fixes #621 Note that `py_venv_*` already mandates that a `main=` label be provided, so this is for legacy `py_binary` only. Should be removed in 2.0. ### Changes are visible to end-users: no - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes The internal `determine_main` targets have been eliminated, simplifying some advanced usages. ### Test plan - Covered by existing test cases --------- Co-authored-by: aspect-marvin[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inlines this into the executable rules instead.
Fixes #605
Fixes #621