Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use relative paths with stylelint #448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JesseTatasciore
Copy link
Member

@JesseTatasciore JesseTatasciore commented Dec 11, 2024

Patch the stylelint compact formatter so that it outputs relative paths. This is needed as by default we were getting paths that included the bazel-out directory


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: no
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Stylelint will now output relative, non-bazel paths

Test plan

  • Covered by existing test cases
  • Manual testing; please provide instructions so we can reproduce:

I ran this using the aspect CLI and produced the following result:

Patch for //src:css from linter mnemonic AspectRulesLintStylelint
Lint results for //src:css:

src/hello.css: line 11, col 5, error - Unexpected empty block (block-no-empty)
src/hello.css: line 16, col 3, error - Unexpected duplicate "color" (declaration-block-no-duplicate-properties)

Some problems have automated fixes available:

  src/hello.css | 1 -
  1 file, 1 deletion(-)

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link to the issue on stylelint that it doesn't support relative paths (file one if it doesn't exist?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants