Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: generated npm_package targets should include package.json main/exports targets #745

Closed
jbedard opened this issue Sep 16, 2024 · 0 comments
Closed

[Bug]: generated npm_package targets should include package.json main/exports targets #745

jbedard opened this issue Sep 16, 2024 · 0 comments
Assignees
@jbedard
Labels
bug Something isn't working

Comments

@jbedard
Copy link
Member

jbedard commented Sep 16, 2024 •
edited
Loading

When gazelle is generating npm packages it should automatically include dependencies declared via package.json fields
@jbedard jbedard added the bug Something isn't working label Sep 16, 2024
@jbedard jbedard self-assigned this Sep 16, 2024
@github-actions github-actions bot added the untriaged Requires traige label Sep 16, 2024
@jbedard jbedard removed the untriaged Requires traige label Sep 16, 2024
@jbedard jbedard closed this as completed Sep 17, 2024
jbedard added a commit that referenced this issue Sep 27, 2024
@jbedard
feat(cli): support package.json main,exports (#6809)
55b293e 
Close #745

Automatically generate npm package deps (`js_library(deps)` or
`npm_package(srcs)`) based on package.json references to
source/generated/compiled files.

---

### Changes are visible to end-users: no

### Test plan

- New test cases added

GitOrigin-RevId: fbb793917693d6e241c52b71ae882650d3bf7f84
jbedard added a commit that referenced this issue Sep 28, 2024
@jbedard
feat(cli): support package.json main,exports (#6809)
85d5c60 
Close #745

Automatically generate npm package deps (`js_library(deps)` or
`npm_package(srcs)`) based on package.json references to
source/generated/compiled files.

---

### Changes are visible to end-users: no

### Test plan

- New test cases added

GitOrigin-RevId: fbb793917693d6e241c52b71ae882650d3bf7f84
jbedard added a commit that referenced this issue Sep 28, 2024
@jbedard
feat(cli): support package.json main,exports (#6809)
cb7d3d3 
Close #745

Automatically generate npm package deps (`js_library(deps)` or
`npm_package(srcs)`) based on package.json references to
source/generated/compiled files.

---

### Changes are visible to end-users: no

### Test plan

- New test cases added

GitOrigin-RevId: fbb793917693d6e241c52b71ae882650d3bf7f84
jbedard added a commit that referenced this issue Sep 28, 2024
@jbedard
feat(cli): support package.json main,exports (#6809)
66b3eac 
Close #745

Automatically generate npm package deps (`js_library(deps)` or
`npm_package(srcs)`) based on package.json references to
source/generated/compiled files.

---

### Changes are visible to end-users: no

### Test plan

- New test cases added

GitOrigin-RevId: fbb793917693d6e241c52b71ae882650d3bf7f84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbedard jbedard

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbedard