This repository has been archived by the owner on Feb 16, 2020. It is now read-only.
Bugfix/fix nodejs child port conflict #1665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't necessary because we fixed the iterator to 24 hour periods, and no longer use the trade time from the last trade (which has only 1 second resolution).
Who thought this would ever have to be considered...
…te' into bugfix/fix_binance_import
Bugfix/fix binance import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixed the EADRRINUSE exception that is thrown when debugging
What is the current behavior? (You can also link to an open issue here)
I see "Child process is died" message alert and EADDRINUSE exception in the console after a child process is started for a process when running the app in debug mode. There are a lot open discussion in nodejs about this issue. Please see:
debugging and fork (Error: listen EADDRINUSE :::5858) nodejs/node#8495 (comment)
Debugger doesn't work for processes which fork other processes nodejs/node#9435
What is the new behavior (if this is a feature change)?
This is a temporary fix. I think using
clusterinstead ofchild_processsolves the problem as mentioned here debugging and fork (Error: listen EADDRINUSE :::5858) nodejs/node#8495 (comment) and as applied here Use cluster to spawn child-processes. rocjs/roc-package-webpack-node#13