Support arm64 for macOS instead of x64 #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the macOS platform support from x64 to arm64 across the codebase. Key changes include:
- Updating the executable mapping in MongoExecutableLocator.cs to use "osx-arm64".
- Modifying ProjectInfo definitions in build/Program.cs for macOS to reference arm64.
- Adjusting the CI workflow to run tests on Ubuntu, Windows, and macOS using updated configurations.
Reviewed Changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EphemeralMongo.Core/MongoExecutableLocator.cs | Changed the macOS executable mapping from "osx-x64" to "osx-arm64". |
| build/Program.cs | Updated ProjectInfo entries for macOS to use "osx-arm64" and "arm64". |
| .github/workflows/ci.yml | Modified CI matrix to include macos-latest for testing. |
Files not reviewed (5)
- src/EphemeralMongo.Runtimes/build/copy-runtimes.targets: Language not supported
- src/EphemeralMongo.sln: Language not supported
- src/EphemeralMongo6/EphemeralMongo6.csproj: Language not supported
- src/EphemeralMongo7/EphemeralMongo7.csproj: Language not supported
- src/EphemeralMongo8/EphemeralMongo8.csproj: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future-proofing macOS support for arm64 instead of x64:
macos-latestrunner uses arm64Modified CI to test on Ubuntu, macOS, and Windows.