Simplify the code using struct #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now payload is a Struct, it's not needed to json encode. Unfurling works with images.
| @@ -29,50 +27,33 @@ type Attachment struct { | |||
| Fields []*Field `json:"fields"` | |||
| } | |||
|
|
|||
| type Payload struct { | |||
| Parse string `json:"parse,omitempty"` | |||
There was a problem hiding this comment.
Can you please format this with go fmt?
|
Except for that one comment - the code doesn't seem to be formatted using |
| func Send(webhookUrl string, proxy string, payload map[string]interface{}) []error { | ||
| data, _ := json.Marshal(payload) | ||
| func Send(token string, proxy string, payload Payload) []error { | ||
| webhookUrl := fmt.Sprintf("https://hooks.slack.com/services/%v", token) |
There was a problem hiding this comment.
@adrianlzt Just happen to see this, sorry :( Can we please stick with full webhook url instead of just token? That way we can support Slack API Compatible services (like Rocket.Chat, etc.) as well.
|
Thank you so much for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now payload is a Struct, it's not needed to json encode.
Unfurling works with images.
Only asks for the token, webhook url is in the code.