Skip to content

Commit

Permalink
Install Reflect[@@toStringTag]
Browse files Browse the repository at this point in the history
This normative PR reached consensus in the July 2020 TC39:
tc39/ecma262#2057

Bug: v8:10768
Change-Id: Ibe2affea0447b923435f77de5d3c0233deeb9877
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327753
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69156}
  • Loading branch information
syg authored and Commit Bot committed Jul 30, 2020
1 parent eab7553 commit e0d382a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions src/init/bootstrapper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3606,6 +3606,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Handle<JSObject> reflect =
factory->NewJSObject(isolate_->object_function(), AllocationType::kOld);
JSObject::AddProperty(isolate_, global, reflect_string, reflect, DONT_ENUM);
InstallToStringTag(isolate_, reflect, reflect_string);

SimpleInstallFunction(isolate_, reflect, "defineProperty",
Builtins::kReflectDefineProperty, 3, true);
Expand Down
3 changes: 0 additions & 3 deletions test/test262/test262.status
Original file line number Diff line number Diff line change
Expand Up @@ -551,9 +551,6 @@
'built-ins/Atomics/xor/bigint/non-shared-bufferdata': [FAIL],
'built-ins/Atomics/xor/non-shared-bufferdata': [FAIL],

# https://bugs.chromium.org/p/v8/issues/detail?id=10768
'built-ins/Reflect/Symbol.toStringTag': [FAIL],

# https://bugs.chromium.org/p/v8/issues/detail?id=10769
'language/expressions/template-literal/invalid-legacy-octal-escape-sequence-8': [FAIL],
'language/literals/string/legacy-non-octal-escape-sequence-8-strict': [FAIL],
Expand Down

0 comments on commit e0d382a

Please sign in to comment.