Add option download_wasmer #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for your PR @Trey2k! I didn't see this until now but was working on something similar in f8a84cfb9ae02ac86dc670e3921d20c729e96a00 after your suggestions here. The only additional consideration to your PR was universalizing the macOS libraries to support Intel and Apple Silicon. Only hiccup seems to be Windows build (of course) using static libs. Edit: I'm gonna go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed some in #3 it would be nice to have an automated way of acquiring wasmer. This PR adds a scons option
download_wasmerwhich defaults to false. When true it will download wasmer for the platform passed to scons. If the wasmer folder already exists, it will skip.