fix(docker): keep tests/ in build context so the media-wiring gate can run - #74
Merged
Merged
Conversation
…n run (NousResearch#143) The docker-publish "Media tool wiring regression gate" runs `pytest tests/tools/test_media_generation_wiring.py` INSIDE the freshly built image. An upstream sync re-added a blanket `tests/` line to .dockerignore, so the test never lands in the image and the gate fails with `file or directory not found: tests/tools/test_media_generation_wiring.py` (no tests ran, exit 4) — blocking the publish even though the image builds fine. Un-exclude tests/ (same class of regression as the apps/ one fixed in NousResearch#141). The fork needs both apps/desktop and tests/ in the build context; upstream excludes both. Restores the fork's prior working state. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of canary
e89f98bba(NousResearch#143 on canary). Un-excludestests/in.dockerignore.Why now: the prod
docker-publish"Media tool wiring regression gate" runspytest tests/tools/test_media_generation_wiring.pyinside the built image, but a blankettests/line in.dockerignorekeeps it out → the gate dies withfile or directory not found(exit 4) and the image publish fails. This has been blocking all prod image builds (pre-existing; unrelated to other changes). Restores parity with canary so the prod fork can publish images again.🤖 Generated with Claude Code