Skip to content

Commit

Permalink
fix(test-tooling): use of hardcoded password
Browse files Browse the repository at this point in the history
Primary Changes
----------------
1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function
defined in openethereum-test-ledger.ts. It was previously optional.
2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the
newEthPersonalAccount function is not hardcoded.

Fixes hyperledger-cacti#2766

Signed-off-by: ashnashahgrover <[email protected]>
  • Loading branch information
ashnashahgrover committed Aug 12, 2024
1 parent fdce6b3 commit a6778b1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export class OpenEthereumTestLedger {
*/
public async newEthPersonalAccount(
seedMoney = 10e8,
password = "test",
password: string,
): Promise<string> {
const account = await this.web3.eth.personal.newAccount(password);

Expand Down

0 comments on commit a6778b1

Please sign in to comment.