fix occasional range error #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi Emilia, Would it be possible to add a test case demonstrating the error? Thanks! |
Author
|
@ashleyw I added a test that I hope clarifies the error I was experiencing! Let me know if you have questions. |
emilia-friedberg
force-pushed
the
fix/range-error
branch
from
03343de to
20cf30f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the
node.lengthin thegetSafeCaretPositionfunction in order to solveIndexErrorthat was arising out of an invalid range length in the instance where the state's value is longer than the length of the node in the ref.