Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fiddle 1.0.8 #14

Closed
wants to merge 147 commits into from
Closed

Try fiddle 1.0.8 #14

wants to merge 147 commits into from

Conversation

ashie
Copy link
Owner

@ashie ashie commented May 24, 2021

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

Docs Changes:

Release Note:

cosmo0920 and others added 30 commits March 15, 2021 17:52
If a file is mv-ed and a new file is created during calling `#refresh_watchers`s, and `#refresh_watchers`
won't run `#start_watchers` and `#stop_watchers` for the path because `#target_paths_hash` always contains the path.

Signed-off-by: Hiroshi Hatake <[email protected]>
…th-file

in_tail: Handle to send rotated logs when mv is used for rotating
Suppress the following message while testing it:

2021-03-17T05:57:52.3545997Z /home/runner/work/fluentd/fluentd/lib/fluent/command/plugin_config_formatter.rb:165: warning: instance variable @table not initialized

Follow up for fluent#3240.

Signed-off-by: Takuro Ashie <[email protected]>
Fill an uninitialized instance variable of FluentPluginConfigFormatter
Fix MessagePackEventStream issue with Enumerable methods
Signed-off-by: TAGOMORI Satoshi <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
These plugins accept a parameter `plugin_type` but it hides the parent
class's method `Fluent::Plugin::Parser#parser_type`, it causes
unexpected behavior on a plugin which uses this method such as in_exec.

Fix fluent#3296

Signed-off-by: Takuro Ashie <[email protected]>
In the previous version, <name> of prefix
is not mentioned.

Before:

  Usage: fluent-plugin-generate [options] <type> <name>

  Generate a project skeleton for creating a Fluentd plugin

  Arguments:
          type: input,output,filter,parser,formatter
          name: Your plugin name

  Options:
          --[no-]license=NAME          Specify license name (default: Apache-2.0)

After:

  Usage: fluent-plugin-generate [options] <type> <name>

  Generate a project skeleton for creating a Fluentd plugin

  Arguments:
          type: input,output,filter,parser,formatter
          name: Your plugin name (fluent-plugin- prefix will be added to <name>)

  Options:
          --[no-]license=NAME          Specify license name (default: Apache-2.0)

Signed-off-by: Kentaro Hayashi <[email protected]>
fluent-plugin-generate: add note about plugin name
In the previous versions, generated .gemspec doesn't follow
depended gem version which is used in fluentd.gemspec at all.

Instead, it is changed to retrieve depended gem version from
Gemfile.lock to sync with it.

Before:

  spec.add_development_dependency "bundler", "~> 1.14"
  spec.add_development_dependency "rake", "~> 12.0"
  spec.add_development_dependency "test-unit", "~> 3.0"

It is required to update manually.

After:

  spec.add_development_dependency "bundler", "~> 2.2.15"
  spec.add_development_dependency "rake", "~> 13.0"
  spec.add_development_dependency "test-unit", "~> 3.3"

Above depended version is replaced by <%= %> in template.
No need to update manually.

Signed-off-by: Kentaro Hayashi <[email protected]>
Use rr 3.0 on unit tests for Ruby 3.0 kwargs changes
parser_csv, parser_syslog: Fix a naming conflict on parser_type
Follow depended gem version by fluent-plugin-generate
There are some failed unit test with Ruby 3.0 on windows,
Instead of omitting those test cases, it may be better
to mark "experimental" to clarify the issues.

Signed-off-by: Kentaro Hayashi <[email protected]>
cosmo0920 and others added 8 commits May 17, 2021 18:21
In recent CRuby, RubyVM::InstructionSequence is always defined.
But other implementation such as truffleruby does not provide such
class.

Signed-off-by: Hiroshi Hatake <[email protected]>
On Windows, a win32 error `ERROR_SHARING_VIOLATION` is occured on
`Fluent::FileWrapper.stat(path)` when a file is temporarily used by
another process. Such files should be skipped safely until the file is
released as same as ENOENT case.

This patch rescues also other EACCES cases although they rarely occur.

Signed-off-by: Takuro Ashie <[email protected]>
…if-only-available

bin: fluentd: Specify trace_instruction as false if available
in_tail: Safely skip files used by another process on Windows
Otherwise it doesn't limit reading pace on reading many short lines.

Signed-off-by: Takuro Ashie <[email protected]>
Use test driver's default one.

Signed-off-by: Takuro Ashie <[email protected]>
in_tail: read_bytes_limit_per_second should precede read_lines_limit
@ashie ashie force-pushed the try-fiddle-1.0.8 branch 9 times, most recently from 8b90ebc to 6c72d25 Compare May 25, 2021 04:31
Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie force-pushed the try-fiddle-1.0.8 branch from 6c72d25 to 1514e9f Compare May 25, 2021 04:37
@ashie ashie closed this May 25, 2021
@ashie ashie deleted the try-fiddle-1.0.8 branch May 25, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants