device: Replace query_count parameter in get_query_pool_results with data.len()
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jul 28, 2022
Comment on lines
-2028
to
+2022
| let data_size = mem::size_of::<T>() * data_length; | ||
| let data_size = mem::size_of_val(data); |
There was a problem hiding this comment.
This effectively incorporates #640; not to fix a "bug" (there was no bug as far as I understood, the caller was using the wrong the type and doing it that way would still result in the wrong stride hence the wrong output for WITH_AVAILABILITY as result N+1 overwrites N), but simply because this otherwise reads mem::size_of::<T>() * data.len() which should be exactly what mem::size_of_val() returns.
…ith `data.len()` A slice is designed to be a cheap view into a continuous segment of memory and easily recreated with a different offset and size. This can be used to our advantage to let the user set exactly how many items they want to request, while ensuring all returned slots are filled on success or otherwise return `NOT_READY` if not enough query results could be copied to user memory (or block if the `WAIT` flag is set). This also opens the door to accepting `MaybeUninit` in the future and returning the initialized slice in the `VkResult::Ok(here)` case.
MarijnS95
force-pushed
the
remove-query-count
branch
from
a248c7a
to
f56fbbc
Compare
Ralith
approved these changes
Jul 29, 2022
MarijnS95
added a commit
that referenced
this pull request
Feb 24, 2023
…y_pool_results()` Commit c66db26 ("device: Replace `query_count` parameter in `get_query_pool_results` with `data.len()` (#644)") removed this parameter in favour of using `data.len()` to make it more obvious to use an appropriate element type that matches the kind of request (see also #639) so that the stride is filled in correctly, but it was not mentioned in the changelog yet.
MarijnS95
added a commit
that referenced
this pull request
Feb 24, 2023
…y_pool_results()` (#710) Commit c66db26 ("device: Replace `query_count` parameter in `get_query_pool_results` with `data.len()` (#644)") removed this parameter in favour of using `data.len()` to make it more obvious to use an appropriate element type that matches the kind of request (see also #639) so that the stride is filled in correctly, but it was not mentioned in the changelog yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #640
A slice is designed to be a cheap view into a continuous segment of memory and easily recreated with a different offset and size. This can be used to our advantage to let the user set exactly how many items they want to request, while ensuring all returned slots are filled on success or otherwise return
NOT_READYif not enough query results could be copied to user memory (or block if theWAITflag is set).This also opens the door to accepting
MaybeUninitin the future and returning the initialized slice in theVkResult::Ok(here)case.