Skip to content

Conversation

@sahandilshan
Copy link
Contributor

Purpose

Fix #553

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 06:53
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.48%. Comparing base (0ae7a70) to head (817697d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   60.63%   60.48%   -0.16%     
==========================================
  Files         147      149       +2     
  Lines       19097    19076      -21     
==========================================
- Hits        11580    11538      -42     
- Misses       6188     6210      +22     
+ Partials     1329     1328       -1     
Flag Coverage Δ
backend-combined-postgres 51.92% <ø> (-0.07%) ⬇️
backend-combined-sqlite 51.92% <ø> (-0.07%) ⬇️
backend-integration-postgres 51.92% <ø> (-0.07%) ⬇️
backend-integration-sqlite 51.92% <ø> (-0.07%) ⬇️
backend-unit 18.44% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reads configuration from environment variables in development and from runtime.json in production for the OAuth sample app, addressing issue #553.

  • Introduces a helper to resolve config values, preferring .env in dev and filtering out placeholder values from runtime.json.
  • Updates config mappings to use the helper and adds redirectUri resolution through the same path.
  • Updates README with separate development and production configuration instructions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
samples/apps/oauth/src/config.tsx Adds getConfigValue helper and updates config resolution to prefer .env in dev and runtime.json in prod.
samples/apps/oauth/README.md Documents dev (.env) vs prod (runtime.json) configuration with examples and precedence notes.

Copy link
Contributor

@ThaminduDilshan ThaminduDilshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's squash and merge

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@sahandilshan sahandilshan requested a review from Copilot October 21, 2025 06:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample app is unable to run with dev mode

2 participants