-
Notifications
You must be signed in to change notification settings - Fork 226
Read values from .env file for the sample app #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 60.63% 60.48% -0.16%
==========================================
Files 147 149 +2
Lines 19097 19076 -21
==========================================
- Hits 11580 11538 -42
- Misses 6188 6210 +22
+ Partials 1329 1328 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Reads configuration from environment variables in development and from runtime.json in production for the OAuth sample app, addressing issue #553.
- Introduces a helper to resolve config values, preferring .env in dev and filtering out placeholder values from runtime.json.
- Updates config mappings to use the helper and adds redirectUri resolution through the same path.
- Updates README with separate development and production configuration instructions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| samples/apps/oauth/src/config.tsx | Adds getConfigValue helper and updates config resolution to prefer .env in dev and runtime.json in prod. |
| samples/apps/oauth/README.md | Documents dev (.env) vs prod (runtime.json) configuration with examples and precedence notes. |
439a169 to
1f60ba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's squash and merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
6f3c034 to
817697d
Compare
Purpose
Fix #553