Skip to content

Conversation

@ThaminduDilshan
Copy link
Contributor

Purpose

This pull request introduces improvements to the project's mock generation workflow and documentation. The main changes include splitting the mockery configuration into separate files for public and private interfaces, updating the Makefile to support these changes, and clarifying the documentation to reflect the new process.

Mock generation workflow enhancements:

  • Added backend/.mockery.private.yml for private interface mocks and renamed backend/.mockery.yml to backend/.mockery.public.yml for public mocks, providing clearer separation and organization of mock configurations. [1] [2]
  • Updated the Makefile to add a new mockery target that generates mocks using both configuration files, and included installation logic for the mockery tool with version management. [1] [2] [3] [4]

Copilot AI review requested due to automatic review settings October 17, 2025 05:44
@ThaminduDilshan ThaminduDilshan added the skip-changelog Skip generating changelog for a particular PR label Oct 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the mock generation workflow by separating public and private interface configurations into distinct files, enhancing organization and clarity. The changes include splitting the mockery configuration, updating build targets, and documenting the new process.

  • Split mockery configuration into separate files for public and private interfaces
  • Added new Makefile target for streamlined mock generation using both configurations
  • Updated documentation to reflect the new mock generation process

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
backend/.mockery.public.yml Added comment for clarity and removed commented-out configuration for cache package
backend/.mockery.private.yml New configuration file specifically for private interface mocks within packages
Makefile Added mockery tool installation, version management, and new target for generating mocks
.github/copilot-instructions.md Updated documentation to reflect the split configuration files and new make command

@ThaminduDilshan ThaminduDilshan merged commit 8fdceb4 into asgardeo:main Oct 17, 2025
4 checks passed
@ThaminduDilshan ThaminduDilshan deleted the thamindu-mocks branch October 17, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip generating changelog for a particular PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants