fix: terraform subdirectory access in module source

[mattp0]

This was introduced in previous v18.5.0.0 release. Plan to fix: delete v18.5.0.0 release and then re-generate the release after this is merged.

[mattp0]

Was reported that this was an issue by NSIDC in slack.

[reweeden]

You could also do a v18.5.0.1. But fine with me to regenerate it I guess.

[mattp0]

You could also do a v18.5.0.1. But fine with me to regenerate it I guess.

My thought is that v18.5.0.0 is broken and this is a fix to it? but I can go either way. Just one I have to update a changelog

[reweeden]

In a real package repository such as pypi you wouldn't have the ability to modify a version once you released it because someone could have built off of it already even with all it's issues. You would just upload a newer version with the bugfix and bump the bugfix version number, that's what it's there for.

For this, it seems like it's unusable in its current state? So not really an issue to completely delete and remake it.

[reweeden]

I guess just keep in mind that this wouldn't be standard practice for software releases generally.