Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution bucket policy resources #87

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

reweeden
Copy link
Contributor

When setting up TEA behind a CloudFront distribution, any buckets that you will be distributing data from need to have a bucket policy that allows the CloudFront OAI to read the data. These bucket policies may be expanded in the future or maybe left to be expanded in the downstream forks.

@reweeden reweeden requested a review from lindsleycj July 28, 2023 22:22
Copy link
Collaborator

@lindsleycj lindsleycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have to apply this when I deployed TEA with Cloudfront. I guess NGAP handled it for me.

I don't have any real way to test it.

If we want it to be in the v17.0.0.0 release, please add a CHANGELOG entry.

Otherwise, I'm fine with adding it.

@reweeden reweeden force-pushed the rew/add-distribution-bucket-policy branch from 0774635 to b7ee95f Compare August 22, 2023 21:39
Copy link
Collaborator

@lindsleycj lindsleycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the bucket policy change into the v17.0.0.0 release in the CHANGELOG

@lindsleycj lindsleycj merged commit b149bd6 into master Aug 23, 2023
1 check passed
@reweeden reweeden deleted the rew/add-distribution-bucket-policy branch October 3, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants