Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix templates install issues #516

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix templates install issues #516

merged 1 commit into from
Dec 12, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Dec 12, 2024

  • fix the deadline context exceeded after import data
    • this was caused by the new timeout duration value in client.Config not being passed alone to the command handler executing the tests.
  • fix directory gateway not getting started
    • this was caused by the mapToGRPCPorts func not being deterministic, the first directory gRPC service in the api map was setting the state, when this is an exporter or importer the gateway definition is empty, resulting in the gateway not to get started. As the information was retrieved from a map, the behavior was undeterministic, based on the order of the map entries.
  • reduced the health service check wait time from 30 to 10 seconds.
  • update service factory to detect HasCA() instead of HasCert() which is more correctly reflecting that the client connection from the gateway to the gRPC service only needs a CA cert.

@gertd gertd requested a review from ronenh December 12, 2024 21:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12304928720

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 12290299490: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@gertd gertd merged commit 17bfe5a into main Dec 12, 2024
5 checks passed
@gertd gertd deleted the fix-templates-install branch December 12, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants