Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract topaz CLI configuration package #234

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Extract topaz CLI configuration package #234

merged 7 commits into from
Jan 17, 2024

Conversation

carabasdaniel
Copy link
Contributor

No description provided.

@carabasdaniel carabasdaniel requested a review from ronenh January 9, 2024 15:20
@coveralls
Copy link

coveralls commented Jan 9, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 7559833428

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.1%) to 37.315%
Totals Coverage Status
Change from base Build 7534029871: -2.1%
Covered Lines: 1462
Relevant Lines: 3918
💛 - Coveralls

@carabasdaniel carabasdaniel marked this pull request as ready for review January 12, 2024 10:05
@carabasdaniel carabasdaniel requested a review from gertd January 12, 2024 10:14
ronenh
ronenh previously approved these changes Jan 12, 2024
View reviewed changes
@ronenh
Copy link
Contributor

ronenh commented Jan 15, 2024

Would it make sense to put the config loader and generator in pkg/cc/config and use it in both topazd and the CLI?

@carabasdaniel
Copy link
Contributor Author

Would it make sense to put the config loader and generator in pkg/cc/config and use it in both topazd and the CLI?

Moved it into pkg/cc for now, but using it in topazd would require further modification to the loader to ensure default values and environment variable handling. Would it make sense for those changes to be in this PR also ?

@carabasdaniel carabasdaniel requested a review from ronenh January 15, 2024 16:58
gertd
gertd reviewed Jan 17, 2024
View reviewed changes
@carabasdaniel carabasdaniel requested a review from gertd January 17, 2024 17:58
@gertd gertd merged commit b7f409b into main Jan 17, 2024
5 checks passed
@gertd gertd deleted the cli_fixes branch January 17, 2024 18:04
@carabasdaniel carabasdaniel mentioned this pull request Jan 19, 2024
Closed
BogdanIrimie pushed a commit that referenced this pull request Feb 22, 2024
@carabasdaniel @BogdanIrimie
Extract topaz CLI configuration package (#234)
ba1493c 
* Extract topaz CLI configuration package

* Update loader

* Use loader get volumes for mount paths

* Update generator

* Move configuration package into topaz cc

* Add config loader and generator to config package

* Remove UI.Progress from cert generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh Awaiting requested review from ronenh

@gertd gertd Awaiting requested review from gertd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carabasdaniel @coveralls @ronenh @gertd