Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Coin Support #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Multi-Coin Support #2

wants to merge 2 commits into from

Conversation

cvolny
Copy link

@cvolny cvolny commented Mar 20, 2014

taviscaron,

The app failed to scan my multi-coin-pool's QR so I think these changes should add support for these. URL is in the form of:
https://mupool.com/index.php?page=api&action=public&coin=LTC

Adding the account fails in the app because without the coin attribute, the server responds with text saying to include that (not JSON). Ex: https://mupool.com/index.php?page=api&action=public.

Anyway, I'm not an Android programmer, but I am a Java programmer (when necessary) so that's why I said I think the changes should work. Let me know what I need to fix if this isn't right as I haven't tested this yet (installing the Android SDK now).

Cheers!

@asenchuk
Copy link
Owner

  1. Yes
  2. You need to implement just onUpgrade, because currently we don't have intents to make any downgrades (onDowngrade is needed in some new version where you're about to rollback the databalse version). The following behavior is expected: user have an some old app version which use DB v1 - database will be updated to v2 on first run and existent accoutns won't be removed; user performs clean install (w/o any existent version) and get clean v2 database.
  3. Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants