-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: rename module and move main
pacakge to cmd/asdf
#85
base: master
Are you sure you want to change the base?
all: rename module and move main
pacakge to cmd/asdf
#85
Conversation
…ests that were being skipped
I should note that |
"asdf/internal/toolversions" | ||
"asdf/internal/versions" | ||
|
||
"github.com/asdf-vm/asdf-core-go/internal/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo (github.com/asdf-vm/asdf-core-go) is temporary and will be archived in a couple weeks. All the changes in this repo will soon be merged into github.com/asdf-vm/asdf once most of the test code in main_test.go
is passing.
Should we make this name github.com/asdf-vm/asdf
? What's the difference between github.com/asdf-vm/asdf
and asdf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module name should match the import path that identifies the repo. If the plan is to move the code into another repo, then it should match the repo it's moved to. It can be renamed now or when it's moved. Alternatively, you can use a vanity URL, i.e. asdf-vm.com
. Then people could, for example, use go install asdf-vm.com/cmd/asdf@latest
to install the command. That would allow you to move repos without having to rename the module. I use a vanity URL, deedles.dev
, for my personal projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with github.com/asdf-vm/asdf
since that is where this code will live in a few weeks. I don't expect many people to use this asdf-core-go
repo, and if they do they'll hopefully see it's not ready for regular use. I've updated the repo description to make this clear.
Thanks for the PR @DeedleFake. I left a few comments. Looks like PR checks failed, I will investigate at a later time. Otherwise looks like something I can merge. |
Fixes #84.
This also fixes a few other minor things, but in so doing causes
go test
to fail because a test was not being run at all before due to being named incorrectly is now running and it fails.