Fixes #916. Add factory methods to create lists #917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
As @glisicivan identified in #916 that the Extension API is currently missing methods to create Lists.
This PR adds the missing methods.
How does it achieve that?
The PR adds the following method to
Processor
and a few overrides if no attributes or options are used:To create an ordered list
"olist"
must be passed as the context parameter.For unordered lists
"ulist"
must be passed.That means to create an ordered list simply call this from within an extension:
Are there any alternative ways to implement this?
An alternative might have been to define methods like
createUnorderedList()
,createOrderedList()
etc.But passing the context as a String closer matches the API for
createBlock()
etc and is closer to the original Ruby API.@mojavelinux Wdyt?
Issue
Fixes #916