(v2.5.x) Fix CI upstream tests #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to remove the pluginRepository to get it running locally: diff --git a/ci/asciidoctor-gem-installer.pom b/ci/asciidoctor-gem-installer.pom
index e03ca15..67230bc 100644
--- a/ci/asciidoctor-gem-installer.pom
+++ b/ci/asciidoctor-gem-installer.pom
@@ -14,12 +14,6 @@
<url>http://rubygems-proxy.torquebox.org/releases</url>
</repository>
</repositories>
- <pluginRepositories>
- <pluginRepository>
- <id>rubygems-releases</id>
- <url>https://rubygems-proxy.torquebox.org/releases</url>
- </pluginRepository>
- </pluginRepositories>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties> |
abelsromero
force-pushed
the
issue-1178-fix-upstream-tests-v2.5.x-branch
branch
from
ad6224f
to
b7eb3d3
Compare
|
Nevermind this branch, I am looking at the |
abelsromero
force-pushed
the
issue-1178-fix-upstream-tests-v2.5.x-branch
branch
from
b7eb3d3
to
1233333
Compare
abelsromero
force-pushed
the
issue-1178-fix-upstream-tests-v2.5.x-branch
branch
from
b1ecf11
to
87ac494
Compare
|
Main branch is completed (if only for improvements), back to this one, I will be testing in my fork, don't worry if there's no activity here. I'll mark as ready when ready. |
abelsromero
force-pushed
the
issue-1178-fix-upstream-tests-v2.5.x-branch
branch
from
87ac494
to
309fa58
Compare
* Bump jruby used for gem installation to 9.2.21.0 * Use s4u/[email protected] * test-asciidoctor-upstream formatting
|
At the end ported the formatting improvements from main branch and it works fine now. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
TLDR; Fix CI upstream tests, same as #1179 but for v2.5.x branch.
How does it achieve that?
Since we need compatibility with Java 8, this PR only does minimal changes (unlike #1179). Simply remove the
gempackaging.Also bump jruby version, not strictly necessary, but I'd rather be on latests versions, you can't never be too paranoid about security.
Are there any alternative ways to implement this?
Same considerations as in #1179.
Are there any implications of this pull request? Anything a user must know?
Yes, always keep your CI healthy green_circle
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1178
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc