Allow gemPath to be specified when using custom classloader

[mojavelinux]

It's not currently possible to specify both the gemPath and a custom classloader. We are missing this permutation in the list of create methods.

Additionally, I think the gemPath should be set to null by default when a custom classloader is specified. Passing a custom classloader is a strong signal that AsciidoctorJ is being run in a modular environment which should be completely isolated. We don't want to leak the global GEM_PATH (or GEM_HOME) when running in such an environment.

It is useful to be able to specify the gemPath for debugging purposes, so I still think we should have it as an option. Just not the default.

Here's the method in question: https://github.com/asciidoctor/asciidoctorj/blob/master/asciidoctorj-core/src/main/java/org/asciidoctor/Asciidoctor.java#L708-L710

[mojavelinux]

Note that this is needed for the Asciidoctor sbt plugin.

[lordofthejars]

I will implement this afternoon so 1.5.2.1 release will contain as well.
El dg., 28 de des., 2014 a les 0.53 Dan Allen [email protected] va
escriure:

Note that this is needed for the Asciidoctor sbt plugin.

—
Reply to this email directly or view it on GitHub
#258 (comment)
.