Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure AsciidoctorJ version is returned always in CLI #1230

Closed
abelsromero opened this issue Jul 2, 2023 · 0 comments · Fixed by #1243
Closed

Ensure AsciidoctorJ version is returned always in CLI #1230

abelsromero opened this issue Jul 2, 2023 · 0 comments · Fixed by #1243
Labels
enhancement

Comments

@abelsromero
Copy link
Member

I see this null check

asciidoctorj/asciidoctorj-cli/src/main/java/org/asciidoctor/cli/jruby/AsciidoctorInvoker.java

Line 93 in 6088e5b

if (in == null) {
and I wonder if we should remove it and ensure the version is always obtainable.

We could keep the check for resiliency, but log a message indicating something went wrong.
robertpanzer added a commit to robertpanzer/asciidoctorj that referenced this issue Nov 20, 2023
@robertpanzer
Fixes asciidoctor#1230. Add test to make sure Asciidoctor version is …
267d74a 
…returned when using --version
@robertpanzer robertpanzer mentioned this issue Nov 20, 2023
Merged
5 tasks
robertpanzer added a commit that referenced this issue Nov 20, 2023
@robertpanzer
Fixes #1230. Add test to make sure Asciidoctor version is returned wh… (
571fa7f 
#1243)

Fixes #1230. Add test to make sure Asciidoctor version is returned when using --version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1230. Add test to make sure Asciidoctor version is returned wh… robertpanzer/asciidoctorj
1 participant
@abelsromero