Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description list term_font_style not respected for literal (mono) text #854

Closed
ctargett opened this issue Sep 22, 2017 · 5 comments
Closed
Assignees
Labels

Comments

@ctargett
Copy link

We're using the description list for parameter names since we like it better than putting them in huge tables. Since these are parameters, we use monospace text for the names. When we generate the PDF, all description_list terms that aren't monospace are bold, but those that are monospace are not. This makes them get a little lost on the page

The font we're using for monospace is Inconsolata, and we have a bold definition for it.

Screenshots of the difference:

non-monospace-descriptionlist

monospace-descriptionlist

We had the same problem with our HTML output (using jekyll-asciidoc), but that was easily fixed via CSS. There isn't such an obvious fix here, though. Any ideas?

@janosvitok
Copy link

Can you post source?

@ctargett
Copy link
Author

Sure, all our source is in the Apache Lucene/Solr project, so open to everyone to read. The example above with monospace is from this file: https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/highlighting.adoc.

If you meant our PDF theme, it's in https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/pdf/themes/refguide-theme.yml.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Oct 25, 2017
@mojavelinux
Copy link
Member

The reason behind this actually fairly complicated. When the text has inline formatting, the style set in the theme is not being passed on. I came up with a fairly simple workaround that uses explicit formatting, though I'd like to take this a bit further and fix the API.

See #862.

@mojavelinux mojavelinux self-assigned this Oct 25, 2017
@mojavelinux mojavelinux added this to the v1.5.0.alpha.17 milestone Oct 25, 2017
@mojavelinux
Copy link
Member

Interestingly, there's an example of this in the chronicles example document. I just never noticed it.

@ctargett
Copy link
Author

Thanks so much, I'll be excited to try it out. We use this in a ton of places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants