Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional spaces added when using footnotes or full URL paths in a paragraph #179

Closed
rlopez133 opened this issue Jun 9, 2015 · 6 comments
Assignees
Milestone

Comments

@rlopez133
Copy link

It seems like whenever I add a footnote or a footnote in a bullet list it seems to add additional unwanted spaces. It does not always do this but seems to happen often enough. I've attached a screenshot from my rendered pdf
selection_200

As for additional spaces added, usually if providing a long URL path within a paragraph it can cause these additional spaces to happen as well. I think it happens usually if the URL wraps to the next line. Easy workaround for this is to just use hyperlinked text.

@mojavelinux
Copy link
Member

What you are observing is the text justification that is used in the default theme. It is attempting to justify the text. A quick way to fix this is to change the default text alignment in your theme:

base:
  align: left

Of course, the fact that the footnote text is being placed inline is also part of the issue here. See #85.

@mojavelinux
Copy link
Member

I think the change I'd like to make here is that "simple" lists (lists that don't have complex content) should be forced to use left alignment. It's very unlikely that you would want justified text in these cases. We could also consider a dedicated key in the theme for this.

@mojavelinux mojavelinux added this to the v1.5.0 milestone Jun 9, 2015
@mojavelinux mojavelinux self-assigned this Jun 9, 2015
@mojavelinux
Copy link
Member

@rlopez133
Copy link
Author

Changing my theme from align: justify to align: left fixed that issue. I was thinking a nice solution would be something similar to http://asciidoctor.org/docs/user-manual/#applying-substitutions as you mentioned in my issue #180. For instance, I create a list and above the list I could set an alignment attribute for that particular list. This gives me the option of say leaving base at whatever alignment I so chose in my theme and modifying the list accordingly via attribute in the doc. Not sure if it can be done like this but figured I'd throw that out there.

@mojavelinux
Copy link
Member

I realized that we have this control for paragraphs:

[.text-left]
Content aligned to left regardless of theme setting.

So we just need to add this is lists as well:

[.text-left]
* align to left
* align to left

I'll file a related issue. See #182.

@mojavelinux
Copy link
Member

mojavelinux commented Jun 15, 2019

All of the proposed changes have been implemented. Starting in alpha.17, you can change the text alignment for list items using:

[.text-left]
* Linpack [Linpack - http://software.intel.com/en-us/articles/intel-math-kernel-library-documentation/] is where it's at

Or for the whole document using:

= Document Title
:text-alignment: left

* Linpack [Linpack - http://software.intel.com/en-us/articles/intel-math-kernel-library-documentation/] is where it's at

It's also possible to extend the default theme (since alpha.18), so it's very easy to apply a small tweak like this:

extends: default
base:
  align: left

or

extends: default
outline_list:
  text_align: left

So you have lots of options now.

sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Dec 29, 2022
Use a nested list with source and severity on separate lines that are
left-aligned instead of justified (also see [1]).

[1]: asciidoctor/asciidoctor-pdf#179

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Dec 29, 2022
Use a nested list with source and severity on separate lines that are
left-aligned instead of justified (also see [1]).

[1]: asciidoctor/asciidoctor-pdf#179

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Dec 29, 2022
Use a nested list with source and severity on separate lines that are
left-aligned instead of justified (also see [1]).

[1]: asciidoctor/asciidoctor-pdf#179

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Dec 29, 2022
Use a nested list with source and severity on separate lines that are
left-aligned instead of justified (also see [1]).

[1]: asciidoctor/asciidoctor-pdf#179

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Dec 30, 2022
Use a nested list with source and severity on separate lines that are
left-aligned instead of justified (also see [1]).

[1]: asciidoctor/asciidoctor-pdf#179

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit to oss-review-toolkit/ort that referenced this issue Dec 30, 2022
Use a nested list with source and severity on separate lines that are
left-aligned instead of justified (also see [1]).

[1]: asciidoctor/asciidoctor-pdf#179

Signed-off-by: Sebastian Schuberth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants