Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support description list in parser doxia module #751 #772

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Feb 10, 2024

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

Add support for description lists https://docs.asciidoctor.org/asciidoc/latest/lists/description/ for the new maven-parser-doxia-module.

Are there any alternative ways to implement this?

It feels like it. The fact that ordered and unordered lists tags are treated in ListItemNodeProcessor but for description lists I had to do the treatment on its own NodeProcessor make me thing there's some flaw in the current approach. But so far it works and release v3 should not be delayed.

Are there any implications of this pull request? Anything a user must know?

no.

Is it related to an existing issue?

  • Yes
  • No

Closes #751

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero abelsromero marked this pull request as ready for review February 11, 2024 10:50
@abelsromero abelsromero force-pushed the branch-main/issue-751-support-description-list-in-parser-doxia-module branch from d21b130 to 4f3c7a2 Compare February 11, 2024 10:52
@abelsromero abelsromero force-pushed the branch-main/issue-751-support-description-list-in-parser-doxia-module branch from 4f3c7a2 to 06e7f1d Compare February 11, 2024 10:53
* Checkpoint: tested all description lists from docs
* Update docs
* Update IT

Closes asciidoctor#751
@abelsromero abelsromero merged commit c8b543a into asciidoctor:main Feb 11, 2024
20 checks passed
@abelsromero abelsromero deleted the branch-main/issue-751-support-description-list-in-parser-doxia-module branch February 11, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Description list" not working for v3 doxia modules
1 participant