Conversation
Add deletion timestamp detection to IntegrationSnapshotChangePredicate so the controller reconciles when a snapshot is being deleted, allowing the finalizer removal logic to run during snapshot GC. Also add the pipelines.appstudio.openshift.io/type=test label to the PLR list filter in RemoveFinalizerFromAllIntegrationPipelineRunsOfSnapshot to ensure only integration test PLRs are matched. Includes tests for predicate behavior and snapshot adapter finalizer removal via envtest. Closes #2 Signed-off-by: Adam Scerra <ascerra@redhat.com>
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deletion timestamp detection to IntegrationSnapshotChangePredicate so the controller reconciles when a snapshot is being deleted, allowing the finalizer removal logic to run during snapshot GC.
Also add the pipelines.appstudio.openshift.io/type=test label to the PLR list filter in RemoveFinalizerFromAllIntegrationPipelineRunsOfSnapshot to ensure only integration test PLRs are matched.
Includes tests for predicate behavior and snapshot adapter finalizer removal via envtest.
Closes #2
Maintainers will complete the following section