Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for hiding native tabs #205

Closed
wants to merge 1 commit into from

Conversation

MasterKia
Copy link
Contributor

@asamuzaK
Copy link
Owner

asamuzaK commented Jul 30, 2022

I do not agree with adding this instruction.

  • The extension does not completely replace the native tab bar, for example, it does not support some context menu items.
  • There is no easy way to restore the native tab bar.
    If you close the sidebar or load something other than this extension into the sidebar, you will have no way to access the tabs.
  • If someone is aware of those above and still want to hide the tab bar, I am sure that they will search and find a solution themselves. Just like you did this time:-)
    So this kind of instruction is unnecessary anyway.

@asamuzaK
Copy link
Owner

How about leaving the link to superuser.com you mentioned above in #5

@MasterKia
Copy link
Contributor Author

  • The extension does not support some context menu items.

How about telling the user which menu items aren't supported so the user could decide that the trade-off is worth it or not?

  • There is no easy way to restore the native tab bar.

Isn't deleting the userChrome.css file an easy way though?
A user who is able to correctly follow that instruction should also be able to delete that file just in case something happens.

  • If someone is aware of those above

How could they be? Actually I wasn't aware that some context menus aren't supported.
But I was indeed aware that if I want to restore native tabs I could just delete the userChrome.css file.

  • I am sure that they will search and find a solution themselves. Just like you did this time:-)

Agreed. I think having the tried and true instruction at hand in this repo isn't a bad idea either.

How about leaving the link to superuser.com you mentioned above in #5

Sounds good to me. But the instructions in that superuser link are a bit scattered across the place (for example the steps to enable the custom css aren't mentioned in the first top answer so user might get confused). So I suggest having the "instruction from this PR + superuser link" in #5.

@asamuzaK
Copy link
Owner

Isn't deleting the userChrome.css file an easy way though?

For light users who copy and use userChrome.css as is without considering the side effects, deleting userChrome.css is not an easy way, IMO.

I suggest having the "instruction from this PR + superuser link" in #5.

Fine with me. Please go ahead with that.

@MasterKia
Copy link
Contributor Author

Fine with me. Please go ahead with that.

Done, you could pin that issue so it's more visible to the users.

@MasterKia MasterKia closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants