Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Example code for issue_052 #53

Merged
merged 2 commits into from
Apr 10, 2020
Merged

WIP: Example code for issue_052 #53

merged 2 commits into from
Apr 10, 2020

Conversation

1beb
Copy link
Contributor

@1beb 1beb commented Mar 17, 2020

This is what I was thinking about as an example. re: #52

Let's say you have thousands of processes running on a cluster or even on one machine in parallel. Without being able to set some type of pid you would see the error come out perfectly but you might not be able to identify the process that spawned it.

My use case might be pretty unique (within a big cluster running a bunch of jobs that need to be repeated over and over as new data comes in). Not sure if you would be interested in keeping these adjustments but figured I would share them all the same.

@aryoda
Copy link
Owner

aryoda commented Mar 29, 2020

Thanks for your contribution! I have pulled it into a local feature branch to do some adjustments and push it as a new feature branch here (in a few days) so that you can give me your feed-back (if you want and have the time for that).

BTW: I would like to name you as contributor in the DESCRIPTION file if this OK for you - I need your email and name then (which is publicly visible!).

@1beb
Copy link
Contributor Author

1beb commented Mar 29, 2020

It's not necessary to include me as contrib as I only spent maybe 30-1 hour working on it. If you insist it's [email protected].

I can definitely review the functionality of your new branch when it's pushed if you want to tag me in a comment or assign me as reviewer.

@1beb
Copy link
Contributor Author

1beb commented Apr 10, 2020

Hey @aryoda wanted to check-in see if there's anything that I can do to help out here. I have some other software that is dependent on this branch but if you're making some changes I'd prefer to use the CRAN version. Let me know!

@aryoda aryoda merged commit ebc8c86 into aryoda:master Apr 10, 2020
@aryoda
Copy link
Owner

aryoda commented Apr 10, 2020

@1beb I have just pushed an updated version to the master branch as release candidate.

Mainly I have

  • added a lot of unit tests,
  • documentation and
  • code to capture invalid argument values.

The new argument is named execution.context.msg now and the signature is:

tryCatchLog <- function(expr,
                        ...,
                        execution.context.msg      = "",
                        finally = NULL,
                        write.error.dump.file      = getOption("tryCatchLog.write.error.dump.file", FALSE),
                        write.error.dump.folder    = getOption("tryCatchLog.write.error.dump.folder", "."),
                        silent.warnings            = getOption("tryCatchLog.silent.warnings", FALSE),
                        silent.messages            = getOption("tryCatchLog.silent.messages", FALSE),
                        include.full.call.stack    = getOption("tryCatchLog.include.full.call.stack", TRUE),
                        include.compact.call.stack = getOption("tryCatchLog.include.compact.call.stack", TRUE)
)

There is no strong need to review the code (but always welcome)
but feed-back on the usability, errors or unclear documentation is always welcome.

I want to wait about four weeks before I submit a new release at CRAN to allow feed-back of other early-adaptor users... I hope this doesn't block you...

Thanks again for for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants