fix CMake config file version compatibility#5221
Merged
Merged
Conversation
Make it the application's responsibility to manage their supported versions. This can be done with CMake find_package() version ranges, for instance.
Contributor
Author
|
This is meant to be merged into |
Contributor
|
@FranciscoPombal |
Contributor
Author
|
@zywo If you install libtorrent to your standard system dirs, it should also work without manually specifying |
Contributor
|
Yes, but I avoid doing |
glassez
reviewed
Oct 15, 2020
Contributor
Author
|
EDIT: wrong issue. |
Owner
|
looks reasonable. @zeule you agree? |
arvidn
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it the application's responsibility to manage their supported
versions.
This can be done with CMake find_package() version ranges, for instance.
Context: qbittorrent/qBittorrent#13510 (comment) and the following two comments below it. An application like qBittorrent might want to support two or more versions at the same time that differ in major and minor version. It is difficult to accomplish this with the
SameMinorVersionrestriction in the generated CMake config files.