Skip to content

fix CMake config file version compatibility#5221

Merged
arvidn merged 1 commit into
arvidn:RC_1_2from
FranciscoPombal:fix_cmake_config
Oct 17, 2020
Merged

fix CMake config file version compatibility#5221
arvidn merged 1 commit into
arvidn:RC_1_2from
FranciscoPombal:fix_cmake_config

Conversation

@FranciscoPombal
Copy link
Copy Markdown
Contributor

Make it the application's responsibility to manage their supported
versions.

This can be done with CMake find_package() version ranges, for instance.


Context: qbittorrent/qBittorrent#13510 (comment) and the following two comments below it. An application like qBittorrent might want to support two or more versions at the same time that differ in major and minor version. It is difficult to accomplish this with the SameMinorVersion restriction in the generated CMake config files.

Make it the application's responsibility to manage their supported
versions.

This can be done with CMake find_package() version ranges, for instance.
@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

This is meant to be merged into RC_2_0 and master as well, of course.

@zywo
Copy link
Copy Markdown
Contributor

zywo commented Oct 15, 2020

@FranciscoPombal
Just tested and works as expected with this command:
cmake -DLibtorrentRasterbar_DIR=~/build/rc_2_0/LibtorrentRasterbar/ ~/qbittorrent/

@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

@zywo If you install libtorrent to your standard system dirs, it should also work without manually specifying LibtorrentRasterbar_DIR (but I think you already know this).

@zywo
Copy link
Copy Markdown
Contributor

zywo commented Oct 15, 2020

Yes, but I avoid doing sudo make install every time I compile libtorrent.

Comment thread CMakeLists.txt
@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

FranciscoPombal commented Oct 15, 2020

EDIT: wrong issue.

@arvidn
Copy link
Copy Markdown
Owner

arvidn commented Oct 15, 2020

looks reasonable. @zeule you agree?

@arvidn arvidn merged commit c7dfdef into arvidn:RC_1_2 Oct 17, 2020
@FranciscoPombal FranciscoPombal deleted the fix_cmake_config branch October 17, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants