Fixed missing name for done notifications #1305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for an issue faced by several users, namely "done" notifications containing an empty
namefields when using specific vendors. See issues #351, #538, #789 and others for more information.The idea is in essence quite simple: if the
nameis no longer present in the notify context (probably due to the second on_publish event mentioned by some issues), try to get it from the live context of the stream that is about to close.I am aware that this may not necessarily be the ideal workaround, but it has proven very useful in our use cases and has given good results on our production systems. I am happy to hear about any other ideas or feedback. 👍