Update PinInput.jsx remove focus from clear

[maxuapro]

please remove focus from clear

[arunghosh]

@maxuapro

Thank you for the contribution :)

The idea behind the focus-on-clear was to set focus on the first element when the values are cleared. Any reason for removing it?

[maxuapro]

there is a reason. I use your code in combination with other inputs for searching purposes, and the pin my user enters is used kinda like an id, so I want to clear PinInput, cs there is no sense to search by id and something else, right? But your current clear function also auto focuses on itself.. which is not good in my case) I think people can easily use focus function if they need it after clear. It just makes more sense. I already fixed this in my own version of your code, but I still suggest you to remove that auto focus feature..

…

On Thu, Aug 24, 2023, 12:39 Arun Ghosh ***@***.***> wrote: @maxuapro <https://github.com/maxuapro> Thank you for the contribution :) The idea behind the focus-on-clear was to set focus on the first element when the values are cleared. Any reason for removing it? — Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASBANW7HAWGQVBZV7ESQ6RLXW4ONDANCNFSM6AAAAAA3YI4KIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[arunghosh]

Thank you for the clarification. Your case makes sense. But not sure if it is good to change the existing behavior. I would rather do it via a prop likefocusOnClear and keep the default true.