Repository navigation
Work sidebar: settled thread lifecycle, two-tier attention, and the agent status surface (ADE-125) #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work sidebar: settled thread lifecycle, two-tier attention, and the agent status surface (ADE-125) #886
Changes from 8 commits
e28f541
b35317a
90e8fce
c869300
bc478a7
adbc479
77386d8
3166b5c
1223c70
92a03a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,6 +81,14 @@ export type PushCliRuntimeSignal = { | |
| runtimeState: string; | ||
| }; | ||
|
|
||
| export type PushSessionAttentionRequest = { | ||
| sessionId: string; | ||
| kind: "chat" | "cli"; | ||
| title: string; | ||
| message: string; | ||
| laneId?: string | null; | ||
| }; | ||
|
|
||
| export type PushPrNotification = { | ||
| kind: PrNotificationKind; | ||
| prNumber: number; | ||
|
|
@@ -1233,6 +1241,33 @@ export function createPushPublisherService(deps: PushPublisherDeps) { | |
| onCliRuntimeSignal(scopeKey, signal); | ||
| }, | ||
|
|
||
| handleSessionAttentionRequested( | ||
| scopeKey: string, | ||
| request: PushSessionAttentionRequest, | ||
| ): void { | ||
| if (disposed || !request.sessionId) return; | ||
| const run = ensureRun(request.sessionId, scopeKey, request.kind); | ||
| run.title = request.title.trim() || "ADE session"; | ||
| run.lane = request.laneId | ||
| ? scopes.get(scopeKey)?.resolveLaneName?.(request.laneId) ?? request.laneId | ||
| : run.lane; | ||
| run.phase = "waiting_for_input"; | ||
| run.detail = request.message; | ||
|
Comment on lines
+1254
to
+1255
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a chat uses Useful? React with 👍 / 👎. |
||
| run.lastActiveAt = now(); | ||
| run.metaResolved = true; | ||
| clearAlertDedupe(`alert:${request.sessionId}:question`); | ||
| enqueueAlert({ | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| sessionId: request.sessionId, | ||
| dedupeKey: `alert:${request.sessionId}:question`, | ||
| render: () => ({ title: run.title || "ADE session", body: request.message }), | ||
| deepLink: `ade://session/${request.sessionId}`, | ||
| threadId: request.sessionId, | ||
| phase: "waiting", | ||
| interruptionLevel: "time-sensitive", | ||
| }); | ||
| scheduleFlush(true); | ||
| }, | ||
|
|
||
| /** Force a flush soon (e.g. right after a device registers). */ | ||
| poke(): void { | ||
| scheduleFlush(true); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.